This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 21dae6ee39 Resolve pagerduty deprecations in tests (#39945)
21dae6ee39 is described below
commit 21dae6ee39e7d7fc09a7f1495c8c243ee9d09b49
Author: Gopal Dirisala <[email protected]>
AuthorDate: Tue Jun 4 23:18:19 2024 +0530
Resolve pagerduty deprecations in tests (#39945)
---
tests/deprecations_ignore.yml | 3 ---
tests/providers/pagerduty/hooks/test_pagerduty.py | 31 ++++++++++++++--------
.../pagerduty/hooks/test_pagerduty_events.py | 14 ++++++----
3 files changed, 29 insertions(+), 19 deletions(-)
diff --git a/tests/deprecations_ignore.yml b/tests/deprecations_ignore.yml
index b75db24f60..2752ccd85e 100644
--- a/tests/deprecations_ignore.yml
+++ b/tests/deprecations_ignore.yml
@@ -466,9 +466,6 @@
-
tests/providers/oracle/hooks/test_oracle.py::TestOracleHookConn::test_set_thick_mode_params
-
tests/providers/oracle/hooks/test_oracle.py::TestOracleHookConn::test_thick_mode_defaults_to_false
-
tests/providers/oracle/hooks/test_oracle.py::TestOracleHookConn::test_thick_mode_dirs_defaults
--
tests/providers/pagerduty/hooks/test_pagerduty.py::TestPagerdutyHook::test_create_event
--
tests/providers/pagerduty/hooks/test_pagerduty.py::TestPagerdutyHook::test_create_event_override
--
tests/providers/pagerduty/hooks/test_pagerduty_events.py::TestPagerdutyEventsHook::test_create_event
-
tests/providers/postgres/hooks/test_postgres.py::TestPostgresHookConn::test_schema_kwarg_database_kwarg_compatibility
-
tests/providers/postgres/operators/test_postgres.py::test_parameters_are_templatized
-
tests/providers/postgres/operators/test_postgres.py::TestPostgres::test_overwrite_database
diff --git a/tests/providers/pagerduty/hooks/test_pagerduty.py
b/tests/providers/pagerduty/hooks/test_pagerduty.py
index f6df40143a..f4ea355665 100644
--- a/tests/providers/pagerduty/hooks/test_pagerduty.py
+++ b/tests/providers/pagerduty/hooks/test_pagerduty.py
@@ -21,6 +21,7 @@ from unittest import mock
import pytest
+from airflow.exceptions import AirflowProviderDeprecationWarning
from airflow.models import Connection
from airflow.providers.pagerduty.hooks.pagerduty import PagerdutyHook
from airflow.providers.pagerduty.hooks.pagerduty_events import
PagerdutyEventsHook
@@ -84,11 +85,15 @@ class TestPagerdutyHook:
def test_create_event(self, events_hook_create_event, events_hook_init):
events_hook_init.return_value = None
hook = PagerdutyHook(pagerduty_conn_id=DEFAULT_CONN_ID)
- hook.create_event(
- summary="test",
- source="airflow_test",
- severity="error",
- )
+ with pytest.warns(
+ AirflowProviderDeprecationWarning,
+ match="This method will be deprecated. Please use the
`airflow.providers.pagerduty.hooks.PagerdutyEventsHook` to interact with the
Events API",
+ ):
+ hook.create_event(
+ summary="test",
+ source="airflow_test",
+ severity="error",
+ )
events_hook_init.assert_called_with(integration_key="integration_key")
events_hook_create_event.assert_called_with(
summary="test",
@@ -109,10 +114,14 @@ class TestPagerdutyHook:
def test_create_event_override(self, events_hook_init):
events_hook_init.return_value = None
hook = PagerdutyHook(pagerduty_conn_id=DEFAULT_CONN_ID)
- hook.create_event(
- routing_key="different_key",
- summary="test",
- source="airflow_test",
- severity="error",
- )
+ with pytest.warns(
+ AirflowProviderDeprecationWarning,
+ match="This method will be deprecated. Please use the
`airflow.providers.pagerduty.hooks.PagerdutyEventsHook` to interact with the
Events API",
+ ):
+ hook.create_event(
+ routing_key="different_key",
+ summary="test",
+ source="airflow_test",
+ severity="error",
+ )
events_hook_init.assert_called_with(integration_key="different_key")
diff --git a/tests/providers/pagerduty/hooks/test_pagerduty_events.py
b/tests/providers/pagerduty/hooks/test_pagerduty_events.py
index 63c60efc5d..3a5df3b616 100644
--- a/tests/providers/pagerduty/hooks/test_pagerduty_events.py
+++ b/tests/providers/pagerduty/hooks/test_pagerduty_events.py
@@ -51,11 +51,15 @@ class TestPagerdutyEventsHook:
"dedup_key": "samplekeyhere",
}
requests_mock.post("https://events.pagerduty.com/v2/enqueue";,
json=mock_response_body)
- resp = hook.create_event(
- summary="test",
- source="airflow_test",
- severity="error",
- )
+ with pytest.warns(
+ AirflowProviderDeprecationWarning,
+ match="This method will be deprecated. Please use the
`PagerdutyEventsHook.send_event` to interact with the Events API",
+ ):
+ resp = hook.create_event(
+ summary="test",
+ source="airflow_test",
+ severity="error",
+ )
assert resp == mock_response_body
def test_create_change_event(self, requests_mock, events_connections):
