jedcunningham commented on code in PR #38697:
URL: https://github.com/apache/airflow/pull/38697#discussion_r1628091310
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -104,8 +104,17 @@ spec:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
resources: {{- toYaml .Values.statsd.resources | nindent 12 }}
- {{- with .Values.statsd.env }}
- env: {{- toYaml . | nindent 12 }}
+ env:
+ {{- if .Values.statsd.env }}
+ {{- toYaml .Values.statsd.env | nindent 12 }}
+ {{- end }}
+ {{- if .Values.config.metrics.metrics_allow_list }}
+ - name: AIRFLOW__METRICS__METRICS_ALLOW_LIST
Review Comment:
Not sure about defaulting it, but if you want to expose it as an optional
config, go for it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
