dstandish commented on code in PR #39951:
URL: https://github.com/apache/airflow/pull/39951#discussion_r1630280157
##########
airflow/models/taskinstance.py:
##########
@@ -553,6 +553,26 @@ def clear_task_instances(
session.flush()
+def record_task_instance_history(ti, session):
+ """Update the task instance history table."""
+ if ti.state not in [
Review Comment:
this seems a bit odd
i would think that we would know, when we call it, whether it should be
recorded
##########
airflow/models/taskinstance.py:
##########
@@ -553,6 +553,26 @@ def clear_task_instances(
session.flush()
+def record_task_instance_history(ti, session):
Review Comment:
should be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
