[
https://issues.apache.org/jira/browse/AIRFLOW-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923269#comment-16923269
]
ASF GitHub Bot commented on AIRFLOW-5342:
-----------------------------------------
mortenbpost commented on pull request #6014: [AIRFLOW-5342] Fix MSSQL breaking
task_instance db migration
URL: https://github.com/apache/airflow/pull/6014
MSSQL does not allow altering columns to NOT NULL when the column
is used in an index. Therefore we drop the ti_pool index and recreate
it after modifying the column.
Co-authored-by: mattinbits <[email protected]>
Co-authored-by: sirVir <[email protected]>
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-5342) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5342
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
AIRFLOW-4591 introduced a breaking migration script on MSSQL server. This
change fixes this.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
MSSQL testing is not officially supported and is not part of the CICD
pipeline. Migrations script changes have been tested on MSSQL locally.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Can't run initdb using Microsoft SQL server
> -------------------------------------------
>
> Key: AIRFLOW-5342
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5342
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration, core, database
> Affects Versions: 1.10.4
> Reporter: Adam Trump
> Assignee: Morten Post
> Priority: Critical
>
> I'm using Microsoft SQL server 2016 as metadata db (for the
> sql_alchemy_conn), and pymssql as the Python driver.
> When running airflow initdb, airflow creates a table named `TaskInstance`
> with column `pool` that is initially Nullable (when the table is created).
> Later, an index named `ti_pool` on a few columns, including `pool` column in
> table `TaskInstance`.
> Then, airflow will try to alter table `TaskInstance` and change the column
> `pool` to `NOT NULL`.
> This does not work on Microsoft SQL Server since a column with an index
> defined on it cannot be changed, unless the index is deleted before.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
