potiuk commented on a change in pull request #5973: [AIRFLOW-XXX] Use full
command in examples
URL: https://github.com/apache/airflow/pull/5973#discussion_r321196592
##########
File path: docs/howto/connection/gcp.rst
##########
@@ -95,4 +95,4 @@ Number of Retries
.. code-block:: bash
-
google-cloud-platform://?extra__google_cloud_platform__key_path=%2Fkeys%2Fkey.json&extra__google_cloud_platform__scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform&extra__google_cloud_platform__project=airflow&extra__google_cloud_platform__num_retries=5
+ export
AIRFLOW_CONN_GOOGLE_CLOUD_DEFAULT='google-cloud-platform://?extra__google_cloud_platform__key_path=%2Fkeys%2Fkey.json&extra__google_cloud_platform__scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform&extra__google_cloud_platform__project=airflow&extra__google_cloud_platform__num_retries=5'
Review comment:
Actually I wrote it initially and - @mik-laj is right: this is all about
making the connection using the environment variable (see line 77). You do not
need to do the same when defining the connection using database as no URL
encoding is needed there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
