RodrigoGanancia opened a new pull request, #40147: URL: https://github.com/apache/airflow/pull/40147
(Implemented SHIFT and CTRL selection) Pressing CTRL adds one extra task to selection, while SHIFT adds a square of tasks Co-authored-by: João Rocha <[email protected]> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> related: #33448 We added a new custom hook useMultipleSelection that stores an array with all selected tasks. Since this is a pretty big feature, we only completed the selection itself and not the state change. We are leaving up to you if we should just hide the functionality of this code to be a base for another PR that implements the state change feature, or continue updating this PR. We would need some opinions on how this functionality should behave when interacting with marking state as. Since changing a state of a task can affect the state of another task, how should the states of multiple tasks be handled. Also for now we've made selected tasks stand out by applying a darker blue background. This helped differentiate between selected tasks, since when multiple tasks within the same rows and columns are chosen it was unclear which tasks were selected. <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
