dybolo commented on code in PR #39873:
URL: https://github.com/apache/airflow/pull/39873#discussion_r1633636998
##########
airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -350,6 +365,24 @@ def _get_credentials_using_credential_config_file(self):
return credentials, project_id
+ def _get_credentials_using_credential_config_file_and_token_supplier(self):
+ self._log_info(
+ "Getting connection using credential configuration file and
external Identity Provider."
+ )
+
+ if not self.credential_config_file:
+ raise AirflowException(
+ "Credential configuration is needed to use authentication by
External Identity Provider."
+ )
Review Comment:
I believe the change you suggested has been addressed
[here](https://github.com/apache/airflow/pull/39873/files#diff-da381f09f5f872e927033b8a3ecd43215dde198d956af677ac425b97603020e0R382).
However, if I've misunderstood any part of your suggestion, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
