jedcunningham commented on code in PR #40156:
URL: https://github.com/apache/airflow/pull/40156#discussion_r1634013967
##########
airflow/serialization/serialized_objects.py:
##########
@@ -831,14 +831,17 @@ def is_serialized(val):
def _serialize_params_dict(cls, params: ParamsDict | dict):
"""Serialize Params dict for a DAG or task."""
serialized_params = {}
- for k, v in params.items():
+ for idx, item in enumerate(params.items()):
+ k, v = item
Review Comment:
```suggestion
for idx, (k, v) in enumerate(params.items()):
```
##########
tests/models/test_serialized_dag.py:
##########
@@ -206,6 +206,23 @@ def test_get_dag_dependencies_default_to_empty(self,
dag_dependencies_fields):
expected_dependencies = {dag_id: [] for dag_id in example_dags}
assert SDM.get_dag_dependencies() == expected_dependencies
+ def test_order_of_dag_params_is_stable(self):
+ """
+ https://github.com/apache/airflow/issues/40154
Review Comment:
```suggestion
```
We can always find the why with git blame. I don't think this case is
noteworthy enough to warrant a permanent link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
