bbovenzi commented on code in PR #40145:
URL: https://github.com/apache/airflow/pull/40145#discussion_r1635308329
##########
airflow/www/templates/appbuilder/navbar_right.html:
##########
@@ -83,7 +83,12 @@
<li><a href="{{user_profile_url}}"><span
class="material-icons">account_circle</span>{{_("Your Profile")}}</a></li>
<li role="separator" class="divider"></li>
{% endif %}
- <li><a href="{{auth_manager.get_url_logout()}}"><span
class="material-icons">exit_to_app</span>{{_("Log Out")}}</a></li>
+ <li class="dropdown">
+ <form method="POST" action="{{auth_manager.get_url_logout()}}">
+ <input type="hidden" name="csrf_token" value="{{ csrf_token() }}"/>
+ <button type="submit" class="btn btn-link"><span
class="material-icons">exit_to_app</span>{{_("Log Out")}}</button>
Review Comment:
A few css suggestions:
- Make the submit button a link:
```
<a
href="javascript:{}"
onclick="document.getElementById('logout').submit();" // add the id to the
form
>
<span class="material-icons">exit_to_app</span>
{{_("Log Out")}}
</a>
```
- You'll need to match the styles from `.dropdown-menu > li > a >
.material-icons` in material-icons.css and from `.dropdown-menu > li > a` in
`bootstrap-theme.css`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
