olivierdolle opened a new issue, #40189:
URL: https://github.com/apache/airflow/issues/40189

   ### Apache Airflow Provider(s)
   
   google
   
   ### Versions of Apache Airflow Providers
   
   I am using `10.14.0`
   but this is true on the latest at the time of writing this issue : `10.19.0`
   
   ### Apache Airflow version
   
   2.6.3
   
   ### Operating System
   
   macos (local)
   
   ### Deployment
   
   Google Cloud Composer
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   The Postgres SQLHook method for insertion expects the argument 
`replace_index` if the argument `replace` is `True`
   It is currently not possible to forward it via `kwargs` and therefore the 
`replace=True` cannot be used.
   
   ### What you think should happen instead
   
   The base class `BigQueryToSqlBaseOperator` does implement accept the 
`replace` argument and it is indeed taken into account until faced with an 
error from the PostgresHook :
   ```
   Traceback (most recent call last):
     File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/providers/google/cloud/transfers/bigquery_to_sql.py",
 line 130, in execute
       sql_hook.insert_rows(
     File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/providers/common/sql/hooks/sql.py",
 line 539, in insert_rows
       sql = self._generate_insert_sql(table, values, target_fields, replace, 
**kwargs)
             
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/providers/postgres/hooks/postgres.py",
 line 310, in _generate_insert_sql
       raise ValueError("PostgreSQL ON CONFLICT upsert syntax requires an 
unique index")
   ValueError: PostgreSQL ON CONFLICT upsert syntax requires an unique index
   ```
   
   Any attempt to pass the `replace_index` argument is met with a dag parsing 
error:
   `airflow.exceptions.AirflowException: Invalid arguments were passed to 
BigQueryToPostgresOperator (task_id: transfer_table_vehicle). Invalid arguments 
were:
   **kwargs: {'replace_index': 'vh_license_plate'}`
   
   ### How to reproduce
   
   Any task with 
   ```python3
   BigQueryToSqlBaseOperator(
     replace=True,
     ...
   )
   
   ```
   
   ### Anything else
   
   This issue is 100% reproducible.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to