jedcunningham commented on code in PR #39920:
URL: https://github.com/apache/airflow/pull/39920#discussion_r1636991768
##########
docs/apache-airflow-providers-amazon/executors/general.rst:
##########
@@ -74,6 +74,13 @@ Then you can build your image by ``cd``-ing to the directory
with the Dockerfile
docker build -t my-airflow-image \
--build-arg aws_default_region=YOUR_DEFAULT_REGION .
+For users on Apple Silicon, you must specify the arch using ``docker buildx``:
+
+.. code-block:: bash
+
+ docker buildx build --platform=linux/amd64 -t my-airflow-image \
Review Comment:
Sorry, I don't have enough context to really have an opinion. My only point
was that, if the platform is consistent, doing it in the dockerfile is less
error prone than an extra arg in `docker build`. If the platform does vary, the
extra arg is the way to go. Let's just say I have first hand knowledge that it
gets missed sometimes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
