jedcunningham commented on code in PR #37893:
URL: https://github.com/apache/airflow/pull/37893#discussion_r1637076040
##########
chart/templates/configmaps/extra-configmaps.yaml:
##########
@@ -37,13 +37,15 @@ metadata:
{{- if $configMapContent.labels }}
{{- toYaml $configMapContent.labels | nindent 4 }}
{{- end }}
- annotations:
- "helm.sh/hook": "pre-install,pre-upgrade"
- "helm.sh/hook-delete-policy": "before-hook-creation"
- "helm.sh/hook-weight": "0"
- {{- if $configMapContent.annotations }}
- {{- toYaml $configMapContent.annotations | nindent 4 }}
- {{- end }}
+ {{- $annotations := dict }}
+ {{- if $configMapContent.useHelmHooks }}
Review Comment:
If we do this, we must do it in such a way that we fall back to true if not
specified for backcompat. And have test coverage for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
