romsharon98 commented on PR #38361: URL: https://github.com/apache/airflow/pull/38361#issuecomment-2172315547
> @nirroz93 good work on the PR. Few comments: > > 1. Can we add this also to `chart/files/pod-template-file.kubernetes-helm-yaml` for K8sExecutor? > 2. Can we add unit tests foe this under `helm_tests`? Check similar tests. > @nirroz93 good work on the PR. Few comments: > > 1. Can we add this also to `chart/files/pod-template-file.kubernetes-helm-yaml` for K8sExecutor? > 2. Can we add unit tests foe this under `helm_tests`? Check similar tests. no need to add this to `chart/files/pod-template-file.kubernetes-helm-yaml` because this feature belongs only to statefulset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
