amoghrajesh commented on code in PR #39897:
URL: https://github.com/apache/airflow/pull/39897#discussion_r1642253661
##########
airflow/providers/apache/druid/hooks/druid.py:
##########
@@ -86,7 +86,10 @@ def get_conn_url(self, ingestion_type: IngestionType =
IngestionType.BATCH) -> s
"""Get Druid connection url."""
host = self.conn.host
port = self.conn.port
- conn_type = self.conn.conn_type or "http"
+ if self.conn.schema:
+ conn_type = self.conn.schema
+ else:
+ conn_type = self.conn.conn_type or "http"
Review Comment:
Can we define "http" as a constant that denoted the default connection type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
