uranusjr commented on code in PR #39278:
URL: https://github.com/apache/airflow/pull/39278#discussion_r1644196493
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -958,7 +958,7 @@ def down(preserve_volumes: bool, cleanup_mypy_cache: bool,
project_name: str):
@option_verbose
@option_dry_run
@click.argument("exec_args", nargs=-1, type=click.UNPROCESSED)
-def exec(exec_args: tuple):
+def exec_(exec_args: tuple):
Review Comment:
I think _this_ change specifically, but there are some variables below that
could use a better rename than just an underscore suffix.
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -958,7 +958,7 @@ def down(preserve_volumes: bool, cleanup_mypy_cache: bool,
project_name: str):
@option_verbose
@option_dry_run
@click.argument("exec_args", nargs=-1, type=click.UNPROCESSED)
-def exec(exec_args: tuple):
+def exec_(exec_args: tuple):
Review Comment:
I think _this_ change specifically is good, but there are some variables
below that could use a better rename than just an underscore suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
