ItaiMeushar opened a new pull request, #40294:
URL: https://github.com/apache/airflow/pull/40294
# Description
#### As mentioned in #17447:
Currently it is not possible to avoid the default Helm annotations on
resources such as ```extraConfigMaps``` and ```extraSecrets``` and there's no
way in ArgoCD to override / ignore those default hooks.
This issue might be related to ArgoCD’s behavior, though it is not certain,
but it can result in pods entering ```CreateContainerConfigError``` state
during updates like when the scheduler is trying to boot up new tasks or when
new Airflow pods are created that depend on extra secrets / configMaps, which
the hooks have just deleted.
### Solution:
The fix in this PR takes after the same approach and conventions used in PR
#18776 for the ```migrateDatabaseJob``` and ```createUserJob``` resources by
using ```useHelmHooks``` flag to decide whether or not to add the Helm hooks
annotations.
### Changes
- Support disabling helm hooks by setting ```useHelmHooks=false``` (by
default the annotations are added)
- Add helm tests
- Update Airflow Helm documentation
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
