o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644791977
##########
tests/jobs/test_backfill_job.py:
##########
@@ -350,9 +377,8 @@ def
test_backfill_respect_max_active_tis_per_dag_limit(self, mock_log, dag_maker
)
dag_maker.create_dagrun(state=None)
- executor = MockExecutor()
-
- job = Job(executor=executor)
+ job = Job()
+ executor = job.executor
Review Comment:
Personally I liked that doing it this way minimized the number of lines of
the diff (the rest of the code in this test can remain the same) and it is used
twice so a variable seemed applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]