This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e3d62c3a59 Fix dag (un)pausing won't work on environment where dag
files are missing (#40345)
e3d62c3a59 is described below
commit e3d62c3a59358d7d2d1bc19f32a3b13c61998c4d
Author: Phong Bui <[email protected]>
AuthorDate: Mon Jul 1 16:34:29 2024 +0700
Fix dag (un)pausing won't work on environment where dag files are missing
(#40345)
closes: #38834
#38265 added bulk pause and resume of DAGs. However, this PR seems to reuse
the cli util method that collects DAGs from the default dag folder but not from
the metadata DB. Hence, this would cause the unpause command to fail on
environments where the dag folder is missing.
---
airflow/cli/commands/dag_command.py | 32 ++++++++++++++++----------------
tests/cli/commands/test_dag_command.py | 13 +++++++++++--
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/airflow/cli/commands/dag_command.py
b/airflow/cli/commands/dag_command.py
index 66444a231d..c574d725e2 100644
--- a/airflow/cli/commands/dag_command.py
+++ b/airflow/cli/commands/dag_command.py
@@ -225,18 +225,24 @@ def dag_unpause(args) -> None:
def set_is_paused(is_paused: bool, args) -> None:
"""Set is_paused for DAG by a given dag_id."""
should_apply = True
- dags = [
- dag
- for dag in get_dags(args.subdir, dag_id=args.dag_id,
use_regex=args.treat_dag_id_as_regex)
- if is_paused != dag.get_is_paused()
- ]
+ with create_session() as session:
+ query = select(DagModel)
+
+ if args.treat_dag_id_as_regex:
+ query = query.where(DagModel.dag_id.regexp_match(args.dag_id))
+ else:
+ query = query.where(DagModel.dag_id == args.dag_id)
+
+ query = query.where(DagModel.is_paused != is_paused)
+
+ matched_dags = session.scalars(query).all()
- if not dags:
+ if not matched_dags:
print(f"No {'un' if is_paused else ''}paused DAGs were found")
return
if not args.yes and args.treat_dag_id_as_regex:
- dags_ids = [dag.dag_id for dag in dags]
+ dags_ids = [dag.dag_id for dag in matched_dags]
question = (
f"You are about to {'un' if not is_paused else ''}pause
{len(dags_ids)} DAGs:\n"
f"{','.join(dags_ids)}"
@@ -245,17 +251,11 @@ def set_is_paused(is_paused: bool, args) -> None:
should_apply = ask_yesno(question)
if should_apply:
- dags_models = [DagModel.get_dagmodel(dag.dag_id) for dag in dags]
- for dag_model in dags_models:
- if dag_model is not None:
- dag_model.set_is_paused(is_paused=is_paused)
+ for dag_model in matched_dags:
+ dag_model.set_is_paused(is_paused=is_paused)
AirflowConsole().print_as(
- data=[
- {"dag_id": dag.dag_id, "is_paused": dag.get_is_paused()}
- for dag in dags_models
- if dag is not None
- ],
+ data=[{"dag_id": dag.dag_id, "is_paused": not dag.get_is_paused()}
for dag in matched_dags],
output=args.output,
)
else:
diff --git a/tests/cli/commands/test_dag_command.py
b/tests/cli/commands/test_dag_command.py
index 535a197eab..6d1e132f44 100644
--- a/tests/cli/commands/test_dag_command.py
+++ b/tests/cli/commands/test_dag_command.py
@@ -717,10 +717,19 @@ class TestCliDags:
mock_yesno.assert_not_called()
dag_command.dag_unpause(args)
- def test_pause_non_existing_dag_error(self):
+ def test_pause_non_existing_dag_do_not_error(self):
args = self.parser.parse_args(["dags", "pause", "non_existing_dag"])
- with pytest.raises(AirflowException):
+ with contextlib.redirect_stdout(StringIO()) as temp_stdout:
dag_command.dag_pause(args)
+ out = temp_stdout.getvalue().strip().splitlines()[-1]
+ assert out == "No unpaused DAGs were found"
+
+ def test_unpause_non_existing_dag_do_not_error(self):
+ args = self.parser.parse_args(["dags", "unpause", "non_existing_dag"])
+ with contextlib.redirect_stdout(StringIO()) as temp_stdout:
+ dag_command.dag_unpause(args)
+ out = temp_stdout.getvalue().strip().splitlines()[-1]
+ assert out == "No paused DAGs were found"
def test_unpause_already_unpaused_dag_do_not_error(self):
args = self.parser.parse_args(["dags", "unpause",
"example_bash_operator", "--yes"])