eladkal commented on code in PR #40418:
URL: https://github.com/apache/airflow/pull/40418#discussion_r1653238892
##########
tests/providers/mysql/operators/test_mysql.py:
##########
@@ -139,7 +141,7 @@ class MySqlHookForTests(MySqlHook):
dbapi_hook = MySqlHookForTests()
- class SQLExecuteQueryOperatorForTest(MySqlOperator):
+ class SQLExecuteQueryOperatorForTest(SQLExecuteQueryOperator):
def get_db_hook(self):
return dbapi_hook
Review Comment:
i am not sure if this is the right way to test?
The `SQLExecuteQueryOperatorForTest` feels strange, we should test the
actual operator I don't see a reason why we need to have extra class on top of
it for testing
I see we do things differently in Postgres
https://github.com/apache/airflow/blob/e8af807cad1eafb52a5e94c1da15cdff2027696c/tests/providers/postgres/operators/test_postgres.py#L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
