bbovenzi commented on code in PR #40639:
URL: https://github.com/apache/airflow/pull/40639#discussion_r1667890533
##########
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##########
@@ -335,11 +351,49 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
// skip
}
}
+ const fieldStr = field as string;
+ try {
+ const fieldJson = JSON.parse(fieldStr);
+ return (
Review Comment:
Oh let's not return inside of the `try/catch` block. Instead just assign the
fieldJson variable inside try/catch and then add a check if its not null inside
the jsx return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
