moiseenkov commented on code in PR #40630:
URL: https://github.com/apache/airflow/pull/40630#discussion_r1668103550
##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -3065,6 +3069,7 @@ def execute(self, context: Context):
project_id=self.project_id,
region=self.region,
gcp_conn_id=self.gcp_conn_id,
+ tags=self.tags,
Review Comment:
In my opinion we shouldn't pass tags to the trigger because the only thing
it is responsible for - is polling the batch by batch_id. Because the batch_id
is unique and sufficient for the batch identification, we probably shouldn't
use tags here. Moreover, this PR doesn't contain any changes for the
`DataprocBatchTrigger`, so it doesn't even accept this parameter.
##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -3098,6 +3104,7 @@ def execute(self, context: Context):
batch_id=self.batch_id,
region=self.region,
project_id=self.project_id,
+ tags=self.tags,
Review Comment:
The same here. If we are waiting for the batch, `batch_id` is enough to
identify it, so we don't have to use rags here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
