e-galan commented on code in PR #40643:
URL: https://github.com/apache/airflow/pull/40643#discussion_r1668401319


##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -3055,6 +3055,13 @@ def execute(self, context: Context):
                     self.log.info("Batch %s created", self.batch_id)
 
                 else:
+                    DataprocBatchLink.persist(

Review Comment:
   It looks like this block is not called in the deferrable mode (which should 
be triggered by `self.defer()`), but in the sync mode if `self.asynchronous` is 
not `True`. 
   
   Could you add some unit tests showing that the link is persisted in the 
deferrable mode?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to