Lee-W commented on code in PR #40478:
URL: https://github.com/apache/airflow/pull/40478#discussion_r1668456361
##########
airflow/datasets/__init__.py:
##########
@@ -159,6 +161,23 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
raise NotImplementedError
[email protected]()
+class DatasetAlias:
+ """A represeation of datasets to be created during the runtime."""
+
+ name: str
+
+ def __str__(self) -> str:
+ return f"DatasetAlias(name={self.name})"
Review Comment:
Removed
##########
airflow/datasets/manager.py:
##########
@@ -58,6 +64,12 @@ def create_datasets(self, dataset_models:
list[DatasetModel], session: Session)
for dataset_model in dataset_models:
self.notify_dataset_created(dataset=Dataset(uri=dataset_model.uri,
extra=dataset_model.extra))
+ def create_dataset_aliases(self, dataset_alias_models:
list[DatasetAliasModel], session: Session) -> None:
+ """Create new dataset aliases."""
+ for dataset_alias_model in dataset_alias_models:
+ session.add(dataset_alias_model)
Review Comment:
Tested and updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
