kacpermuda commented on code in PR #40589:
URL: https://github.com/apache/airflow/pull/40589#discussion_r1668897741
##########
airflow/providers/openlineage/utils/utils.py:
##########
@@ -269,6 +269,25 @@ class TaskInfo(InfoJsonEncodable):
}
+class TaskInfoComplete(TaskInfo):
+ """Defines encoding BaseOperator/AbstractOperator object to JSON used when
user enables full task info."""
+
+ includes = []
+ excludes = [
+ "_BaseOperator__instantiated",
+ "_dag",
+ "_hook",
+ "_log",
+ "_outlets",
+ "_inlets",
+ "_lock_for_execution",
+ "handler",
+ "params",
+ "python_callable",
+ "retry_delay",
Review Comment:
I think we can remove some (suggestion below) or even all stuff from here.
It'll not be serialized anyway, so we'll get e.g.
`python_callable:"<<non-serializable: function>>"`. No strong opinion on this
one, but I don't see why we should exclude anything if it's turned on
explicitly now.
```suggestion
"_BaseOperator__instantiated",
"_dag",
"_hook",
"_log",
"_outlets",
"_inlets",
"_lock_for_execution",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
