uranusjr commented on code in PR #40478:
URL: https://github.com/apache/airflow/pull/40478#discussion_r1669786850


##########
airflow/datasets/metadata.py:
##########
@@ -33,7 +33,18 @@ class Metadata:
 
     uri: str
     extra: dict[str, Any]
-
-    def __init__(self, target: str | Dataset, extra: dict[str, Any]) -> None:
+    alias: list[DatasetAlias | str] | None

Review Comment:
   This should probably be called `aliases` (plural) instead. Is `None` special 
here, or we could just use an empty list instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to