dabla opened a new pull request, #40669:
URL: https://github.com/apache/airflow/pull/40669
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: [#39572](https://github.com/apache/airflow/pull/39572)
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Refactored the get_sqlalchemy_engine method in DbAPiHook so it's using the
uri as well as the connection for creating an engine, which in most cases
nowadays isn't working for a lot of database dialects anyway and which also
bypasses the know issues with the get_uri method in combination with sqlalchemy
that will be fixed in [#39572](https://github.com/apache/airflow/pull/39572).
Beside that this PR also added the autocommit parameter to the insert_rows
method of the DbAPiHook, just like it is already the case with the run method.
This is a preparation for a new PR that will introduce an
SQLInsertRowsOperator, which will be a convenient operator allowing you to
insert rows using an operator instead of the need to use a PythonOperator in
combination with the already existing insert_rows method of the DbApiHook, that
way it will be directly possible to pass an XCom containing the rows to persist
to the operator which aren't directly feasible by using the TransferOperator,
for example in the case of have to download data from a REST endpoint and
persisting it directly to a database.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
