dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1671184984
##########
airflow/executors/base_executor.py:
##########
@@ -122,6 +123,7 @@ class BaseExecutor(LoggingMixin):
job_id: None | int | str = None
name: None | ExecutorName = None
callback_sink: BaseCallbackSink | None = None
+ task_context_logger: TaskContextLogger
Review Comment:
ok so let's try to resolve the question of whether to make this class public
or not. by adding it to base executor, you effectively make it public, since
base executor is public and then providers depend on it.
my thought is, maybe rather than making the whole class public, we could
just add a single method to base executor e.g.
```python
def send_message_to_task_logs(level, msg, *args, ti):
```
then internally this method would use task context logger, but the class
itself it would not need to be made public, since it's hidden from users /
executor implementers.
any thoughts @potiuk @pankajkoti @jedcunningham ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
