dstandish commented on code in PR #39825:
URL: https://github.com/apache/airflow/pull/39825#discussion_r1671211627
##########
airflow/models/baseoperator.py:
##########
@@ -1245,11 +1245,21 @@ def dag(self) -> DAG: # type: ignore[override]
@dag.setter
def dag(self, dag: DAG | None):
"""Operators can be assigned to one DAG, one time. Repeat assignments
to that same DAG are ok."""
- from airflow.models.dag import DAG
-
if dag is None:
self._dag = None
return
+
+ # if already set to elided, then just set and exit
+ if self._dag is ELIDED_DAG:
Review Comment:
yeah, i didn't land on ELIDE just for the sake of being esoteric. it's
actually a very specific thing and there was not a word could find that
described it better.
the sense in which i use it is like, it's intentionally removed (but you
can't say "deleted" since that implies the dag is deleted).
maybe it's not such a bad thing to have to look up the word :)
anyway, omit is close. how about simply `MISSING_DAG`????
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
