vincbeck commented on code in PR #40690:
URL: https://github.com/apache/airflow/pull/40690#discussion_r1672504696


##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -197,8 +206,14 @@ def is_authorized_view(
         )
 
     def is_authorized_custom_view(
-        self, *, method: ResourceMethod | str, resource_name: str, user: 
BaseUser | None = None
+        self,
+        *,
+        method: ResourceMethod | str,
+        resource_name: str,
+        user: BaseUser | None = None,
+        **kwargs,
     ):
+        # TODO: remove this if block when min_airflow_version is set to higher 
than 2.9.0

Review Comment:
   I need a coffee a think 



##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -197,8 +206,14 @@ def is_authorized_view(
         )
 
     def is_authorized_custom_view(
-        self, *, method: ResourceMethod | str, resource_name: str, user: 
BaseUser | None = None
+        self,
+        *,
+        method: ResourceMethod | str,
+        resource_name: str,
+        user: BaseUser | None = None,
+        **kwargs,
     ):
+        # TODO: remove this if block when min_airflow_version is set to higher 
than 2.9.0

Review Comment:
   You're right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to