uranusjr commented on code in PR #39912:
URL: https://github.com/apache/airflow/pull/39912#discussion_r1675270211
##########
airflow/decorators/base.py:
##########
@@ -550,11 +550,13 @@ def __attrs_post_init__(self):
super(DecoratedMappedOperator,
DecoratedMappedOperator).__attrs_post_init__(self)
XComArg.apply_upstream_relationship(self,
self.op_kwargs_expand_input.value)
- def _expand_mapped_kwargs(self, context: Context, session: Session) ->
tuple[Mapping[str, Any], set[int]]:
+ def _expand_mapped_kwargs(
+ self, context: Context, session: Session, *, include_xcom: bool = True
Review Comment:
Since this is internal code, I think we should make `include_xcom` a
required argument so it’s always a conscious decision to include xcom or not.
It is too easy to get this wrong otherwise (especially since the
default—True—is insecure).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
