KevinYang21 commented on issue #5908: Revert "[AIRFLOW-4797] Improve 
performance and behaviour of zombie de…
URL: https://github.com/apache/airflow/pull/5908#issuecomment-528978208
 
 
   @seelmann For sure, mb missed the issue described in the JIRA. Basically 
wrong scope zombie detection logic is placed inside the dag processor manager 
loop. A straightforward fix can be to extract the logic from heartbeat method 
to the the outter scope and then send the same version of zombies until the 
next zombie detection. If the subprocess zombie detection is really preferred, 
we can later bind the zombie detection logic with dag dir refresh logic to make 
sure that we send the same version of zombies to the dag file processors in the 
same round. I'll just go ahead and apply the straightforward fix. But I'm open 
to any other approach addressing the original zombie detection problem. Then 
later we can optimize the logic if desired. Does it make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to