potiuk commented on code in PR #40753:
URL: https://github.com/apache/airflow/pull/40753#discussion_r1676262610
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -546,15 +547,20 @@ def _process_spark_submit_log(self, itr: Iterator[Any])
-> None:
match = re.search("application[0-9_]+", line)
if match:
self._yarn_application_id = match.group(0)
- self.log.info("Identified spark driver id: %s",
self._yarn_application_id)
+ self.log.info("Identified spark application id: %s",
self._yarn_application_id)
Review Comment:
It does not break ENOUGH. I keep on repeating that every single change
breaks something that someone else **might** rely on. This is Hyrum's Law:
https://www.hyrumslaw.com/ in a full swing.
We should just decide wheter:
a) it changes part of our Public interface:
https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html
b) whether it has high probability to break many of our users's workflows
(one or few is not enouhg to qualify as breaking)
In this case answer to both questions is `NO` :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
