kaxil edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-528982114 > That last point is interesting - cos at the SQL level we still need to write it as a string. I wonder if previously we were JSONing things twice (I.e. in the JSON coloum in the db we were storing single string of the JSON represention (`"(\"key\”:\”val\"}"` type of thing)? Not sure. Currently in this PR the data is stored in a **str** column (`sa.Column('data', sa.Text(), nullable=False`)) . We were using `json.dumps` to convert python dict to str and then store it in this column. So I feel we were not double-serializing. Last Night in this commit: https://github.com/astronomer/airflow/commit/2ab9c9b803a5697410c649337fe0602c3b852654 I changed it to Json columns and removed all json.loads & `json.dumps` code. I think you were under the assumption that we already changed to json columns or maybe I might be missing something. I will update this PR with the json column thing with the migration code you suggested (wasn't able to do it yet with 1.10.5 and other things).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
