softyoungha opened a new pull request, #40775:
URL: https://github.com/apache/airflow/pull/40775

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   Hello,
   
   I have made some modifications to the existing `PythonVirtualenvOperator` to 
upgrade a few areas. 
   I am currently working on deploying Airflow on a k8s cluster using Helm, and 
using the `venv_cache_path` of PythonVirtualenvOperator to utilize Airflow in a 
multi-python environment.
   
   Although it is possible to pre-configure Python and use 
ExternalPythonOperator, in a Helm environment this would require building the 
image first. 
   Therefore, we use PythonVirtualenvOperator along with cache_path.
   > A major advantage is the ability to set the requirements directly within 
the DAG file.
   > It's a great feature!
   
   Since Python-executable settings are often shared and reused among various 
tasks, I used to define a custom PythonVirtualenvOperator, but I thought it 
could be improved with a hook.
   It could allow control via the web UI. 
   
   ### Ideas
   
   Just like SparkSubmitHook and SparkSubmitOperator, I separated the methods 
embedded in PythonVirtualenvOperator into a PythonVirtualenvHook, allowing the 
operator to call the hook.
   I will upload the draft first and add the test code later.
   
   
   ### hook screenshot
   
   
![image](https://github.com/user-attachments/assets/b6cf3074-4bf6-4b53-aad6-1c3b96078678)
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to