seyoon-lim commented on code in PR #40757:
URL: https://github.com/apache/airflow/pull/40757#discussion_r1677189342


##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -281,10 +310,57 @@ def _resolve_connection(self) -> dict[str, Any]:
     def get_conn(self) -> Any:
         pass
 
+    def _get_keytab_from_base64(self, base64_keytab: str, principal: str | 
None) -> str:

Review Comment:
   yeah, it actually does 
`get_or_create_keytab_path_from_base64_encoded_keytab_value` 
   
   actually, this function is not strictly dependent on `spark_submit.py`, so 
I'm considering moving it to a separate utility module. (I've taken this into 
account while writing the test code.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to