dabla commented on PR #40746: URL: https://github.com/apache/airflow/pull/40746#issuecomment-2227958747
> There are likely edge cases though (I didn’t check but it’s very likely). Let’s not try too hard on this. Yes but if you are worried of potential side-effects even when using a context manager, and I wasn't aware of this as I'm not that long in Pyhton, then I would opt for the later solution. And yes maybe there will be edge cases, BUT, at least it will be safe AND it's a new funcitonality, which means that if you don't pass the locale as argument, you're still using the original solution. If something would fail in combination wiht the locale, we can always fix it. All test cases are good with above solution, I would personally prefer this one over a hackish solution with context manager, wasn't happy about it in the first place so it's a good thing you pointed this out! ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
