syedahsn commented on PR #40778: URL: https://github.com/apache/airflow/pull/40778#issuecomment-2229493294
>Code changes look fine, but should this have a unit test? There wasn't a unit test initially that tested original behavior, so I didn't write one to test the updated behavior. As far as I can tell, there are no tests related to metrics being emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
