shahar1 commented on code in PR #40806:
URL: https://github.com/apache/airflow/pull/40806#discussion_r1679952580


##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1901,6 +1901,7 @@ def _orphan_unreferenced_datasets(self, session: Session 
= NEW_SESSION) -> None:
                 isouter=True,
             )
             .group_by(DatasetModel.id)
+            .where(~DatasetModel.is_orphaned)

Review Comment:
   Not too familiar with this area, but is it possible to create/update an 
existing unit test to check for this condition? (maybe as part of 
`tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_dataset_orphaning`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to