howardyoo commented on PR #40802: URL: https://github.com/apache/airflow/pull/40802#issuecomment-2234033191
cool, will modify the code to not subtract 1 and push it out :-). Thanks for the comments! On Wed, Jul 17, 2024 at 1:02 PM Jarek Potiuk ***@***.***> wrote: > ***@***.**** commented on this pull request. > > This looks good. And except try_number the tests should be fixed. > > BTW. Hint to other reviewers - selecting "hide whiltespaces" help > enormously in review as there are a number of whitespace-only indentation > changes. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/40802#pullrequestreview-2183644436>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHZNLLVZRLN6H6PWFC7YAHDZM2WUVAVCNFSM6AAAAABK5KFCK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBTGY2DINBTGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
