uranusjr commented on code in PR #40847:
URL: https://github.com/apache/airflow/pull/40847#discussion_r1682408210
##########
airflow/models/renderedtifields.py:
##########
@@ -153,6 +154,23 @@ def _redact(self):
for field, rendered in self.rendered_fields.items():
self.rendered_fields[field] = redact(rendered, field)
+ @classmethod
Review Comment:
A thought not totally tied to this PR. Should the internal API calls use
`staticmethod` instead, since they never use `cls`? Or _can_ they use `cls`?
They should if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
