vincbeck commented on PR #40872:
URL: https://github.com/apache/airflow/pull/40872#issuecomment-2237370929
> I might have added a comment to say why it is different from the rest, but
I'll approve it. Thanks for fixing this.
If `PubliclyAccessible` is not provided to the service, it considers it as
`True`. Thus, when passing `False` to `publicly_accessible`, with the current
code, it does not set it, which is then considered as `True` for Redshift.
Removing the if solves that issue
```
if self.publicly_accessible:
params["PubliclyAccessible"] = self.publicly_accessible
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
