dabla commented on issue #39586: URL: https://github.com/apache/airflow/issues/39586#issuecomment-2238579143
> ### Description > Currently, we allow users to pass dialect via `sqlalchemy_scheme` extra field of the `mssql` connections. > > https://github.com/apache/airflow/blob/3873b098130ff4b8c1b8a37ac596be7b560c62ca/airflow/providers/microsoft/mssql/hooks/mssql.py#L80 > > I am proposing to remove this field as it is not possible to support multiple dialects without installing the relevant dialect driver. Also, the [documentation page](https://airflow.apache.org/docs/apache-airflow-providers-microsoft-mssql/stable/connections/mssql.html) does not even mention about `sqlalchemy_scheme` or the possibility of using other dialects. > > ### Use case/motivation > Supporting multiple dialects requires the installation of multiple drivers. Since we only install `pymssql`, this allows the usage of the `mssql+pymssql` dialect alone and not others. > > I am also interested in updating the documentation to reflect this. > > ### Related issues > _No response_ > > ### Are you willing to submit a PR? > * [x] Yes I am willing to submit a PR! > > ### Code of Conduct > * [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md) I would not remove that property, we for example are actually using is as we have installed multiple drivers (pymssql/odbc/jdbc/...) to access multiple databases. Indeed the 'sqlalchemy_scheme' schould be documeneted, especially in the case of the JdbcHook are there it is required to define it if you want to use the sqlalchemy engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
