sunank200 commented on code in PR #40084:
URL: https://github.com/apache/airflow/pull/40084#discussion_r1684175306
##########
airflow/sensors/time_delta.py:
##########
@@ -73,14 +73,10 @@ def execute(self, context: Context) -> bool | NoReturn:
# If the target datetime is in the past, return immediately
return True
try:
- trigger = DateTimeTrigger(moment=target_dttm)
+ trigger = DateTimeTrigger(moment=target_dttm, end_task=True)
except (TypeError, ValueError) as e:
if self.soft_fail:
raise AirflowSkipException("Skipping due to soft_fail is set
to True.") from e
raise
- self.defer(trigger=trigger, method_name="execute_complete")
-
- def execute_complete(self, context, event=None) -> None:
- """Execute for when the trigger fires - return immediately."""
- return None
+ self.defer(trigger=trigger, method_name=TaskDeferred.TRIGGER_EXIT)
Review Comment:
This value is irrelevant when the task is finished anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
