dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684834538
##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
@expose("/clear", methods=["POST"])
@auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
- @action_logging
+ @action_logging(event="marked cleared")
Review Comment:
> same question, why are you using « marked » in all the action?
because with the state there is no way to tell that it is a user action.
there are machine-generated events recorded for `success` and `running`.
we must put something in the event name to distinguish from those and to
make clear it's a user action.
it's necessariy for `marked failed` and `marked success` because someone is
manually marking those states. it's not for `cleared` because that verb
implies already that it is a manual action i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
