dstandish commented on code in PR #40894:
URL: https://github.com/apache/airflow/pull/40894#discussion_r1685019082
##########
airflow/serialization/pydantic/taskinstance.py:
##########
@@ -458,9 +458,9 @@ def schedule_downstream_tasks(self, session: Session | None
= None, max_tis_per_
:meta: private
"""
- return TaskInstance._schedule_downstream_tasks(
- ti=self, session=session, max_tis_per_query=max_tis_per_query
- )
+ # we should not schedule downstream tasks with Pydantic model because
it will not be able to
+ # get the DAG object (we do not serialize it currently).
+ return
Review Comment:
preface: i don't care about mini scheduler, so i'm not saying you need to
implement this method.
but just on the point... i don't think you need to parse the dag. the dag
has already been parsed. whenever we run a task, we do so after parsing the dag
again. and we pass the dag object around in earlier parts in the task
execution process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
