jx2lee commented on code in PR #40270:
URL: https://github.com/apache/airflow/pull/40270#discussion_r1685457830
##########
helm_tests/other/test_redis.py:
##########
@@ -185,6 +185,32 @@ def test_redis_by_chart_password_secret_name(self,
executor):
self.assert_broker_url_env(k8s_obj_by_key,
expected_broker_url_secret_name)
+ @pytest.mark.parametrize("executor", CELERY_EXECUTORS_PARAMS)
+ def
test_redis_by_chart_password_secret_name_without_broker_url_secret(self,
executor):
+ k8s_objects = render_chart(
+ RELEASE_NAME_REDIS,
+ {
+ "executor": executor,
+ "redis": {
+ "enabled": True,
+ "passwordSecretName": "test-redis-password-secret-name",
+ },
+ "env": [
+ {"name": "AIRFLOW__CELERY__BROKER_URL_CMD", "value":
"test-broker-url"},
+ ],
+ "enableBuiltInSecretEnvVars": {
+ "AIRFLOW__CELERY__BROKER_URL": False
+ }
+ },
+ )
+ k8s_obj_by_key = prepare_k8s_lookup_dict(k8s_objects)
+ created_redis_objects = SET_POSSIBLE_REDIS_OBJECT_KEYS &
set(k8s_obj_by_key.keys())
+
+ assert created_redis_objects == SET_POSSIBLE_REDIS_OBJECT_KEYS - {
Review Comment:
What other values should i look at `assert`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
