potiuk commented on issue #6045: [AIRFLOW-5433] Add script to check external 
links in docs
URL: https://github.com/apache/airflow/pull/6045#issuecomment-529125186
 
 
   One more comment - readarray does not work on Mac. So we should really make 
those changes:
   - move it to in_container dir
   - add lynx in Dockerfile to be installed for the ci image
   - make a pre-commit script to run using docker (similarly as 
pylint/mypy/flake8).
   
   This way we will make it works for everyone (in Docker) without having to 
install anything and we can make it part of the pre-commit. Also the script 
should take as an input the list of files (.rst) to run on - this way 
pre-commit framework will be able to make the check for many files in parallel 
(that's the beauty of the pre-commit framework that it automatically 
parallelise such checks).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to