potiuk commented on code in PR #40173:
URL: https://github.com/apache/airflow/pull/40173#discussion_r1686410461
##########
generated/provider_dependencies.json:
##########
@@ -404,6 +404,7 @@
"devel-deps": [],
"plugins": [],
"cross-providers-deps": [
+ "common.compat",
Review Comment:
I believe so. Compat must be installed in order to use the new method. Maybe
we could add some feature to mark it as optional if you think it makes sense in
this case, but I am not sure if it's really optional. I am not sure if just
TYPE_CHECKING is enough - generally the assumption was that if you use or
expect anything coming from different providers, it is added as
cross-dependency. For example it is also used to see if you should run tests
for the other provider if the "cross-related" one has been modified (and in
this case it's good because it mght cause problems and failing tests if it did
not.
FIY the code doing it is here:
https://github.com/apache/airflow/blob/e30f8102b2dfc2c99454c99c286138754e4a1f1c/scripts/ci/pre_commit/update_providers_dependencies.py#L167
So if you think we can improve that ... :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
