potiuk commented on a change in pull request #6045: [AIRFLOW-5433] Add script
to check external links in docs
URL: https://github.com/apache/airflow/pull/6045#discussion_r321982061
##########
File path: docs/check_links.sh
##########
@@ -47,6 +48,37 @@ echo
echo "Working in ${MY_DIR} folder"
echo
+if [[ ! -f _build/html/index.html ]]; then
+ echo "You should build documentation first."
+ echo
+ echo "If you use the breeze environment then you can do it using the
following command:"
+ echo "./breeze --build-docs"
+ echo
+ exit 1
+fi
+
+if [[ -f /.dockerenv ]]; then
Review comment:
I think we should only run it in docker container. There is no need to run
it outside of it and readarray is not working for vast majority of our users
(from the experience vast majority of Airflow developers use MacOS and
readarray won't work there).
Let's keep to "standard" development environment we already have - Breeze +
docker. I think this should be explicitly "in_container" script and it should
fail if run outside of it.
Doing this we also encourage people to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
