shahar1 commented on code in PR #40924:
URL: https://github.com/apache/airflow/pull/40924#discussion_r1686822585
##########
airflow/sensors/base.py:
##########
@@ -155,8 +171,8 @@ class BaseSensorOperator(BaseOperator, SkipMixin):
and AirflowFailException, the sensor will log the error and continue
its execution. Otherwise, the sensor task fails, and it can be retried
based on the provided `retries` parameter.
- :param never_fail: If true, and poke method raises an exception, sensor
will be skipped.
- Mutually exclusive with soft_fail.
+ Mutually exclusive with soft_fail.
+ :param skip_policy:
Review Comment:
Description needs to be added, probably with details about each option in
the enum.
On the way, I'd include answers to the following questions:
1. What is a "soft" error?
2. What's the difference between "ignore" and "skip"? (it might not be as
trivial for the user)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
